#124 ✓ resolved
subotic

Can't open a project folder

Reported by subotic | March 30th, 2009 @ 10:04 AM

Since the last update (0.6.2) I get the error: "The document "......" could not be opened. GitX cannot open files in the "Standard folder" format".

I'm just trying to open a folder that contains a git repository like I have done so numerous times before (with 0.6.1). Some project folders I can still open with the new version, but some I can't.

Comments and changes to this ticket

  • Johannes Gilger

    Johannes Gilger March 30th, 2009 @ 12:15 PM

    • State changed from “new” to “open”

    Hm, I can't reproduce this problem. Please supply us with the following information:

    • How are you trying to open the folder? File->Open? Drag-and-drop? gitx from terminal?
    • What kind of folder/repo are you trying to open? A bare one? A regular one? One with a remote worktree?
    • Can you supply us with the repos/folders that cause problems?
    • Which git-version are you running?
  • subotic

    subotic March 30th, 2009 @ 01:28 PM

    • git version: 1.6.2.1 (the same behavior with 1.6.1.3)
    • OS: Mac OSX 10.5.6 (intel)
    • Trying to open with "File->Open"
    • a git repository created with "git clone" and doing regularly local commits, push and pulls -sorry but it's commercial work and thus can't send you the directory.
  • subotic

    subotic March 30th, 2009 @ 01:51 PM

    now this is interesting. just looked at the console log. If I open the project in question with 0.6.1 I get the following error (but gitx opens it anyway):

    30.03.09 13:37:16 [0x0-0x748748].nl.frim.GitX[32858] fatal: Not a git repository (or any of the parent directories): .git

    Now the question is why gitx thinks that the folder is not a git repository (I'm opening the folder that contains the .git folder and not the .git folder itself).

  • Sharebear

    Sharebear March 30th, 2009 @ 03:44 PM

    I'm seeing the same problem with one of my repositories. My problematic repo is one which was a bare clone using git svn (version 1.6.0.2). I have another complete clone (different repository) that works fine, so it's not git svn that's causing the problem... could be the bare repo

  • Sharebear

    Sharebear March 30th, 2009 @ 03:47 PM

    Sorry, a little mis-information there... not a bare clone, but a shallow clone "git svn clone -r HEAD ..."

  • Sharebear

    Sharebear March 30th, 2009 @ 04:03 PM

    But a fresh (shallow) clone of another project actually works without problem.

  • Sharebear

    Sharebear March 30th, 2009 @ 04:46 PM

    in commit 3e21d041efb95b6358c749e021bf5ddbcc05bcd7 you added the entry that is supposed to open any file or folder but the role is set to none instead of Viewer as it is for the .git entry.

  • Johannes Gilger

    Johannes Gilger March 30th, 2009 @ 06:13 PM

    Hm, yeah, I'm also seeing now that this had not the effect I intended it to have.

    Since I can't reproduce your issue I'd suggest the following: Try editing the Info.plist in your GitX-installation to use "Viewer" instead of "None" for CFBundleTypeRole and see if this fixes it (/Applications/GitX.app/Contents/Info.plist line 17)

    I'm sorry for this mess, but I'm not really deep into the whole MacOS-structure at this point and it is documented kinda bad.

  • Pieter de Bie

    Pieter de Bie March 31st, 2009 @ 02:41 AM

    Do you guys have a dot in the directory name? Can you try without the dot?

  • Sharebear

    Sharebear March 31st, 2009 @ 09:19 AM

    Yes, that seems to be the problem, if there is a dot in the directory name and it does not end with .git then it fails to open.

    Folder without dot works

    
$ mkdir testgit
$ cd testgit/
$ git init
Initialized empty Git repository in /Users/jshare/Source/foo/testgit/.git/
$ open -a GitX .

    Folder with .git works

    
$ mkdir test.git
$ cd test.git/
$ git init
Initialized empty Git repository in /Users/jshare/Source/foo/test.git/.git/
$ open -a GitX .

    Folder with dot but does not end in .git doesn't

    
$ mkdir test.foo
$ cd test.foo/
$ git init
Initialized empty Git repository in /Users/jshare/Source/foo/test.foo/.git/
$ open -a GitX .

    Changing Role of "Standard folder" to Viewer doesn't seem to fix the issue for me.

  • Sharebear

    Sharebear March 31st, 2009 @ 09:25 AM

    Deleting the entire "Standard folder" mapping from Info.plist "fixes" things for me (I would never have even imagined dragging a folder to the GitX icon so I doubt I will miss the feature)

  • Johannes Gilger

    Johannes Gilger March 31st, 2009 @ 11:15 PM

    Ok, since I didn't want to completely revert the drag-and-drop-to-dock functionality (no, I don't use it neither, but some people seem to do) I began digging around and learned nil. So, in the spirit of Open Source Software I had a look at how the VLC-project is doing it, and sure enough, now everything seems to work just fine, satisfying everyones needs.

    Commit is at http://github.com/heipei/gitx/co... on my usual bugfixes-branch at http://github.com/heipei/gitx/tr...

  • Pieter de Bie

    Pieter de Bie April 1st, 2009 @ 01:00 PM

    Ok, I have no idea what the options exactly mean, but I'll trust you and merge it in next time. Thanks! :)

  • golgote

    golgote April 30th, 2009 @ 07:02 PM

    Just to confirm, I also have a dot in my folder's name and I have the same error message.

  • Pieter de Bie

    Pieter de Bie May 1st, 2009 @ 03:18 PM

    • State changed from “open” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

GitX is the nice-looking gitk clone for OS X

People watching this ticket

Referenced by

Pages