#148 feature
Derek P.

Flagging "important" commits in history view

Reported by Derek P. | May 7th, 2009 @ 07:26 PM | in 0.8

It'd be nice if I could flag a commit in the history view and filter based on that.

Comments and changes to this ticket

  • Johannes Gilger

    Johannes Gilger May 28th, 2009 @ 12:21 PM

    • Milestone set to 0.8
    • Tag changed from enhancement, feature to commit, enhancement, feature, flags
    • State changed from “new” to “open”
    • Assigned user cleared.

    Hm, I'd say this is a major feature (if it is agreed to include it) since this goes beyond git functionality. We'd have to store those flags ourselves, which means their own data-structure, file access and so on.

    One option would be to introduce git-tags called "important-" and "urgent-" for those "flags", but's that not what people might want.

    I'm tagging this for 0.8 right now, though it doesn't mean it will be accepted.

  • Pieter de Bie

    Pieter de Bie May 28th, 2009 @ 12:24 PM

    One idea is to use the new 'git notes' command (since 1.6.3 or so?) to
    annotate stuff. Another (very easy) way to do this is by making it
    non-persistent, and just including a BOOL important in the PBGitCommit
    object.

  • Johannes Gilger

    Johannes Gilger May 28th, 2009 @ 12:37 PM

    • Assigned user set to “Pieter de Bie”

    Hm, yeah, but as I understood it this is supposed to be persistent, as with tagging mails with Thunderbird (which is a great way to do it btw).

    If we were to use git-notes we should really wait a few months before releasing this as stable, so 1.6.3 has a chance to trickle down to the users. Or we'd have to include a version-check, which doesn't really appeal to me.

  • Pieter de Bie

    Pieter de Bie May 28th, 2009 @ 01:13 PM

    well, we already have a version check in GitX, so it wouldn't be too
    hard to do. However, it'd be nice if more than a few people can use
    the feature. I'm also not sure what the performance impact of
    something like that would be.

  • Johannes Gilger

    Johannes Gilger June 9th, 2009 @ 10:43 PM

    Hm, git-notes isn't in master nor in origin/pu anymore. Junio reverted the merge of it so the possibility of us using it seems far away.

  • Lucas Neves Martins

    Lucas Neves Martins July 27th, 2009 @ 10:58 PM

    I think Johannes is right on using Git Tags, since git/versionControl wise, is what a developer should do to mark a specific commit.

    GitX already support showing the Git Tags, it just doesn't let we create it.

    May I suggest a UI mockup? How may I post images here?

  • Dave Grijalva

    Dave Grijalva March 13th, 2010 @ 02:29 PM

    • State changed from “open” to “feature”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

GitX is the nice-looking gitk clone for OS X

Pages