Gitx GitX

Comments and changes to this ticket

• 

  Jeff Hamilton May 15th, 2009 @ 12:57 AM

  I don't know ObjC so haven't been able to track down the problem very well, but after some poking I discovered that forcing PBGitRepository isBareRepository to return NO gets commit mode to work on these symlinked repositories. Running "git rev-parse --is-bare-repository" from the command line does return false as would be expected.

• 

  Jeff Hamilton May 15th, 2009 @ 02:41 AM

  • Title changed from “Commit mode doesn't like symlinks in .git” to “Commit mode doesn't work when core.bare isn't set”

  I talked to Shawn Pearce about this a bit and he pointed out that when using repo to manage the git repositories .git/config ends up not having core.bare set, which he guessed could cause the problem. I verified that was the case by manually setting it in the config file, and things worked as expected. Repo does some interesting things and can't set the bare property for real since the copy that is symlinked to is an actual bare repository and commands get run in both places.

• 

  Johannes Gilger May 20th, 2009 @ 04:38 PM

  Ok, for displaying repos without the core.bare in their config I've written a patch. It's short, still took me some time to figure out the problem (which hopefully I clarified in the commit-message). The commit is in my bugfixes-branch: http://github.com/heipei/gitx/commits/bugfixes

  Please comment if you've got a better idea to do this (right now we can handle the cases of bare repos, non-bare repos with/without core.bare, non-bare repos with core.bare = true. The only case that still breaks gitx (though this is pathological) is setting "core.bare = false" in a bare repo.

• 

  Pieter de Bie May 20th, 2009 @ 04:55 PM

  Hmm, the bare repository thing doesn't do what I had expected. In that
  case, we might as well drop it completely and just return ![self
  workingDirectory]..

• 

  Pieter de Bie May 28th, 2009 @ 04:45 PM

  • State changed from “new” to “resolved”

  I'll keep your fix for now. When rewriting this stuff (which I still plan to do), we might simplify it like I said, but if this works, then whatever :)