#16 ✓ resolved
Daniel Luz

Toolbar display mode is reset when switching views

Reported by Daniel Luz | October 16th, 2008 @ 10:09 AM

Whenever you toggle between History and Commit, the toolbar is reset to its default state.

By preferences, I mean button size (cmd-click on the toolbar toggle button) and toolbar visibility (by switching modes through the View menu).

Comments and changes to this ticket

  • Pieter de Bie

    Pieter de Bie October 16th, 2008 @ 01:33 PM

    • Title changed from “Toolbar preferences are reset when toggling between History and Commit views” to “Toolbar display mode is reset when switching views”
    • State changed from “new” to “open”

    Hmm, that is annoying.

    I'm really not happy with how we handle views now (I don't like the GUI part and the implementation part), but I'm not sure how to make a better GUI. I think GitX is the only app that changes the toolbar when switching views.

    I think there's an easy fix for this issue, however, so I'll try to fix it soon.

  • Pieter de Bie

    Pieter de Bie October 16th, 2008 @ 02:58 PM

    • State changed from “open” to “resolved”

    Fixed in 5cb842ca6b6f10ccdccac4f499a5190fae2cdf6a (PBGitRepositoryWindow: keep toolbar DisplayMode when switching views)

  • Daniel Luz

    Daniel Luz December 1st, 2008 @ 08:10 AM

    • Tag set to feature, view

    Sorry for the long delay, but I just saw the change. It works fine now, but… wouldn't it be better if the change were persistent? :)

  • Pieter de Bie

    Pieter de Bie December 1st, 2008 @ 01:56 PM

    Yes, I was working on that. I fixed it partially in my latest HEAD, but it still has some problems (removing a button and then placing it back disables it), but I guess it's better than nothing :)

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

GitX is the nice-looking gitk clone for OS X

People watching this ticket

Tags

Pages