Switching between commits while browsing the tree view should keep focus on selected file when possible.
Reported by Dave Grijalva | September 4th, 2009 @ 12:59 AM
Following these steps:
- Open a project to the history view - Select the file tree view
from the bottom pane - Select a file, especially one nested in the
folder tree - Select a different commit in the top pane
Expected Result:
The file selected in the bottom pane should remain selected and
update to show it's state in the selected commit as long as the
file still exists in the newly selected commit.
Actual Result:
The view is completely reset, selection is lost, expanded folders
are closed.
When trying to find when a file changed, I'll often try to just select a file in the tree browser and step through commits until I find what I'm looking for. It would be way less frustrating if this view could remember the state of the browser and keep it consistent where possible.
Selection is the most important thing to me, but I could see folder expansion also being valuable if you wanted to browse how files have been moved/renamed/whatever between commits.
Comments and changes to this ticket
-
Johannes Gilger September 4th, 2009 @ 08:50 AM
Hi Dave,
I'm afraid this ticket is a duplicate of #137. I had already tried solving this one before, but it's not that simple because you have to deal with that NSTreeController-thing.
So in order to keep the selection you'd have to (somehow) do the following things:
- Have a look at the selected object and it's filename
- Remember it
- When loading a new commit find the new tree-node/node-id which
corresponds to your file (if it's still there)
- Select it
Step 3 is what I've been hung up on so far.
- Have a look at the selected object and it's filename
-
Johannes Gilger September 5th, 2009 @ 09:41 AM
- State changed from “new” to “invalid”
Closing it now (ticket state should include "duplicate" btw)
-
Dave Grijalva March 12th, 2010 @ 02:38 AM
- State changed from “invalid” to “duplicate”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
GitX is the nice-looking gitk clone for OS X
Johannes Gilger