#199 ✓ resolved
David Genord II

Position for divider between commit history and diff viewer improperly memorized

Reported by David Genord II | September 10th, 2009 @ 04:01 PM

In the history view, the divider between the commit history and diff viewer drifts down changing the pane proportions each time the program is quit and restarted. I do not remember experiencing this prior to version 0.7.

Comments and changes to this ticket

  • Pieter de Bie

    Pieter de Bie September 10th, 2009 @ 04:06 PM

    I've noticed this too, it's very annoying. I think this happens since
    Johannes' collapsible stuff. Perhaps he has any clue as to why it
    happens?

  • Johannes Gilger

    Johannes Gilger September 10th, 2009 @ 05:03 PM

    • State changed from “new” to “small”

    Hm, this is true. And although something is saved in the plist, nothing is restored when the program is loaded. Right now it looks like autosaving the position isn't even possible. I'd try to implement.

    Are you guys sure this worked in older version?

    Pieter: By the way, why did you create the PBNiceSplitView class with the divider? The divider from IB looks just the same to me, and can directly be used in vertical split.

  • Johannes Gilger

    Johannes Gilger September 10th, 2009 @ 05:58 PM

    Oh, nevermind, the pane-splitter-thingy is Mac-OS 10.6 only. The second feature that is exclusive (but that also means we can get rid of PBNiceSplitView and easily make the view vertical-splittable in the future).

  • Pieter de Bie

    Pieter de Bie September 13th, 2009 @ 11:32 PM

    Hmm, I just looked into it too. I'm pretty sure it used to work, but I
    can't get it to work at all, even if I use a plain NSSPlitView. I have
    no idea what's going on here.

    supporting a vertical view should be possible even now, by just adding
    another image, right?

  • Pieter de Bie

    Pieter de Bie September 21st, 2009 @ 10:11 PM

    Fixed, ugly, in e901894c35 (HistoryController: remember location of the split view)

  • Pieter de Bie

    Pieter de Bie September 21st, 2009 @ 10:18 PM

    • State changed from “small” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

GitX is the nice-looking gitk clone for OS X