Remove default text when no commits are found
Reported by dbr/Ben | December 11th, 2009 @ 02:49 AM
An incredibly trivial bug, which should be equally trivial to fix.
Create a new, empty repository, launch gitx. In the lower pane, the following appears:
Author: Pieter de Bie
Date: Pieter de Bie
Subject: Pieter de Bie
I imagine this is just a default string in Interface Builder.. About the most trivial bug imaginable..
Comments and changes to this ticket
-
Gautam Dey January 3rd, 2010 @ 07:45 AM
It was trivial, it's in the index.html file. I have changed it out to be blank. You can pull from my repo to check out the change:
http://github.com/gdey/gitx -
Gautam Dey January 3rd, 2010 @ 07:56 AM
Here is a patch:
html/views/history/index.html | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/html/views/history/index.html b/html/views/history/index.html
index 65117c3..e9ad54b 100644
--- a/html/views/history/index.html +++ b/html/views/history/index.html @@ -27,23 +27,23 @@</tr> <tr> <td class="property_name">Author:</td>-
<td id="authorID">Pieter de Bie</td> -
<td id="authorID"></td><td class="property_name">Date:</td> -
<td id="date">Pieter de Bie</td> -
<td id="date"></td><td class="property_name">Committer:</td> -
<td id="committerID">Pieter de Bie</td> -
<td id="committerID"></td><td class="property_name">Commit Date:</td> -
<td id="committerDate">Pieter de Bie</td> -
<td id="committerDate"></td><td class="property_name">Subject:</td> -
<td id="subjectID" style="font-weight:bold">Pieter de Bie</td> -
<td id="subjectID" style="font-weight:bold"></td>
-- 1.6.0.2.GIT<td class="property_name">Refs:</td>
-
-
Gautam Dey January 3rd, 2010 @ 07:58 AM
@@@Trying Again:
html/views/history/index.html | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/html/views/history/index.html b/html/views/history/index.html
index 65117c3..e9ad54b 100644
--- a/html/views/history/index.html +++ b/html/views/history/index.html @@ -27,23 +27,23 @@</tr> <tr> <td class="property_name">Author:</td>-
<td id="authorID">Pieter de Bie</td> -
<td id="authorID"></td><td class="property_name">Date:</td> -
<td id="date">Pieter de Bie</td> -
<td id="date"></td><td class="property_name">Committer:</td> -
<td id="committerID">Pieter de Bie</td> -
<td id="committerID"></td><td class="property_name">Commit Date:</td> -
<td id="committerDate">Pieter de Bie</td> -
<td id="committerDate"></td><td class="property_name">Subject:</td> -
<td id="subjectID" style="font-weight:bold">Pieter de Bie</td> -
<td id="subjectID" style="font-weight:bold"></td>
-- 1.6.0.2.GIT<td class="property_name">Refs:</td>
-
-
Gautam Dey January 3rd, 2010 @ 08:03 AM
Here is a patch.
html/views/history/index.html | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/html/views/history/index.html b/html/views/history/index.html index 65117c3..e9ad54b 100644 --- a/html/views/history/index.html +++ b/html/views/history/index.html @@ -27,23 +27,23 @@
<td class="property_name">Author:</td>-
Pieter de Bie -
Date: -
Pieter de Bie -
Committer: -
Pieter de Bie -
Commit Date: -
Pieter de Bie -
Subject: -
Pieter de Bie - -- 1.6.0.2.GIT
Refs:
-
-
Gautam Dey January 3rd, 2010 @ 08:05 AM
html/views/history/index.html | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/html/views/history/index.html b/html/views/history/index.html
{mkd-extraction-0cf13a9c0681cda7cf2db9f592f1ba20}
index 65117c3..e9ad54b 100644
--- a/html/views/history/index.html +++ b/html/views/history/index.html @@ -27,23 +27,23 @@- {mkd-extraction-cf70b7b0f545d61c55ecde0c61e3f8e7}
- {mkd-extraction-af24dea2e85f89dbdb64b7078326b4a2} {mkd-extraction-6785fb099da83b2ce28e95a88828fb41}
- {mkd-extraction-cf6d4ca8c506475cebd6e8f4810e8c94}
- {mkd-extraction-ea633812bf9e39d131c1ec69227e0784} {mkd-extraction-daf636c57dc70b01dc1cfce6e341aff7}
- {mkd-extraction-f97a0d02302f4872e8fb4f0b8b7560b8}
- {mkd-extraction-36c49d374afef55c7b1d7510e0ecfd77} {mkd-extraction-81f222e8b12210cb2b217eaad478e381}
- {mkd-extraction-9f174ebc02d4a84904cf3289f7d18252}
- {mkd-extraction-0d4cd8b72809ff4015f3a871e5054217} {mkd-extraction-27369619cfaf5806cf11acea0e45dfe0}
- {mkd-extraction-de2e556b952ebd25967a1af0e2c3ad0a}
- {mkd-extraction-156ff1dde5d8806c78fdacf616571ae1}
{mkd-extraction-5ca3162241ad9954a58519ce333d2db6} --
1.6.0.2.GIT
-
Gautam Dey January 3rd, 2010 @ 08:07 AM
I give up on lighthouse. Here is a gist of the diff.
http://gist.github.com/267865Sorry, for the previous entries.
-
Dave Grijalva March 13th, 2010 @ 01:52 PM
- State changed from “new” to “resolved”
- Assigned user changed from “Pieter de Bie” to “Dave Grijalva”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
GitX is the nice-looking gitk clone for OS X
dbr/Ben