#14 ✓resolved
Scott Guelich

GitX freezes with Safari 4 preview

Reported by Scott Guelich | October 11th, 2008 @ 06:56 PM

This appears to affect both 0.4 and 0.4.1. There appear to be issues both with the Sparkle update check and after loading the repository.

I updated git to 1.6.0.2 via MacPorts (git-core) and tried running GitX 0.4.

After choosing my project directory, the window initially came up listing my commits. But there was a spinner and it was unresponsive. I thought perhaps it took a while to load so I left it for a couple minutes but eventually force-quit it.

The second time it came up again but this time there was a Sparkle window indicating there was a new version. However the HTML content area of the Sparkle window was blank - just a activity spinner. Again I got a rainbow spinner cursor. After waiting a while I eventually force-quit.

I went to the website and manually downloaded GitX 0.4.1. When I launched it, the window came up blank with the spinner cursor. I force-quit, removed preferences, and tried again... repeatedly. I tried with another repository. Each time it prompted for a directory, showed an empty window, and locked up with the rainbow spinning cursor.

Then after several attempts it suddenly asked at startup if I wanted to check for updates. I clicked the manual button. This time the window came up with my commit messages, but still locking up with the spinning cursor. I am attaching the crash report for this run.

The only console message (each time) is "fatal: not a git repository".

Comments and changes to this ticket

  • Pieter de Bie

    Pieter de Bie October 11th, 2008 @ 11:32 PM

    • State changed from “new” to “open”

    Hey,

    I see that you have a few weird plugins, like Instant Hijack Server and PlugSuit. Could you uninstall those and try again?

    The only console message (each time) is "fatal: not a git repository".

    That is probably harmless

  • Pieter de Bie

    Pieter de Bie October 12th, 2008 @ 12:56 PM

    Also, you might want to try if "gitx --commit" on the cli does work.

  • pkqk

    pkqk October 13th, 2008 @ 03:20 AM

    I'm also getting the same problem. I don't have either of those tools installed.

    In the console there were errors about the SIMBL and Edit in Textmate input managers related garbage collection compatibility. It still hangs when they are removed.

    gitx --commit didn't hang initially, it did have the spinner below for a while saying 'Refreshing index', and it hung as soon as I switched to the history tab.

  • Pieter de Bie

    Pieter de Bie October 13th, 2008 @ 05:38 PM

    I'm sorry, I won't be able to fix this without a better crash log or a reproducible test case.

    It looks like it is related to the WebView though.

  • pkqk

    pkqk October 14th, 2008 @ 01:45 AM

    If it's related to the web view it may be that I have the Safari 4 preview installed?

  • Pieter de Bie

    Pieter de Bie October 14th, 2008 @ 02:44 PM

    Yes, that's certainly possible. I'm not sure how the Safari 4 preview works exactly (whether it installs a new system-wide WebKit.framework) but it might cause some weird interference.

    Is it easy to uninstall it? You might want to test that. Scott, do you also have the Safari 4 preview?

  • pkqk

    pkqk October 14th, 2008 @ 02:53 PM

    It seems to just install a new systemwide WebKit.framework and replaces the Safari.app

    So unless the problems it's causing are bugs, chances are this will crop up for more people once Safari 4 is out.

    Also for me this problem only started happening once you put out 0.4; 0.3 worked fine. Did you start using more of the webview from then on?

  • Pieter de Bie

    Pieter de Bie October 14th, 2008 @ 03:08 PM

    Yes, a lot has changed in webviews since 0.3. However, most of them are JS-related and shouldn't make anything crash.

    In the commit view, are you able to see a diff of your changes? That already rules out a large part.

    One of the things that might be the culprit is that GitX now reads in the refs for a commit, i.e. this change:

     diff --git a/html/commit.js b/html/commit.js
     @@ -2,16 +2,18 @@ var commit;
      var Commit = Class.create({
          initialize: function(obj) {
              this.raw = obj.details;
     +        this.refs = obj.refs;
     +        this.object = obj;
    
    

    You could try to set those to nil instead and see if it loads (open the GitX.app bundle, and edit commit.js there).

    I'm testing some of GitX's functionality (like the diff view) with the latest webkits, and don't have any problem. I think Christian also tried GitX with some webkit nightlies, and had success with a few of them (but had GitX crash with others).

    If Safari 4 comes out, it'll be easy enough to fix, as at that point I can try myself. I'm not really motivated to install the Safari 4 preview.

  • Scott Guelich

    Scott Guelich October 14th, 2008 @ 05:15 PM

    Sorry for the delayed response -- had exams the last couple days.

    I also had the Safari 4 Developer Preview installed. I just downloaded the installer and uninstalled it, and after a reboot GitX works fine. So Safari 4 does seem to be the issue.

  • Pieter de Bie

    Pieter de Bie October 15th, 2008 @ 12:33 AM

    • State changed from “open” to “hold”
    • Tag changed from freeze to freeze, webkit

    Sounds like that is the problem them.

    I'll close this ticket for now as I see no way to fix it. If Safari 4 comes out with the same problems, I'll come up with a fix. For now I hope it's a bug in the preview.

    If anyone has success stories of Safari 4 + GitX, please let me know.

  • Pieter de Bie

    Pieter de Bie October 15th, 2008 @ 12:46 PM

    • Title changed from “GitX freezes after launch” to “GitX freezes with Safari 4 preview”
  • Pieter de Bie

    Pieter de Bie October 21st, 2008 @ 08:57 PM

    • State changed from “hold” to “resolved”

    Should be fixed since

    36c550f8cde71858a982be77c6fb8ec231149891 (Merge branch 'pu/pb/remove_prototype')
    
    

    You can download a nightly at http://gitx.frim.nl/Downloads to test it.

  • albert zhu

    albert zhu December 10th, 2018 @ 08:38 AM

    GitX runs on Mac OS X 10.5 Leopard and Mac OS X 10.6 Snow Leopard. Because it uses features like Garbage Collection, you can't compile it on earlier systems. GitX also requires a fairly recent Git -- version 1.6.0 and higher are all supported.

  • ronn91

    ronn91 July 2nd, 2019 @ 09:20 AM

    Nice! thank you so much! Thank you for sharing. Your blog posts are more interesting and informative. I think there are many people like and visit it regularly, including me.
    light novel

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

GitX is the nice-looking gitk clone for OS X

People watching this ticket

Attachments

Tags

Referenced by

Pages