#17 ✓resolved
Stephen Celis

Prototype freezes OS X with Safari 4

Reported by Stephen Celis | October 17th, 2008 @ 11:24 PM | in 0.5

The title says most of it. The window loads and renders nicely, but the application freezes shortly thereafter.

My system.log has a curious notification:


Oct 17 16:14:57 MacBook GitX[1018]: Quick Look loaded!
Oct 17 16:14:57 MacBook GitX[1018]: Error loading /Library/InputManagers/Chax/Chax.bundle/Contents/MacOS/Chax:  dlopen(/Library/InputManagers/Chax/Chax.bundle/Contents/MacOS/Chax, 265): no suitable image found.  Did find:\n	/Library/InputManagers/Chax/Chax.bundle/Contents/MacOS/Chax: GC capability mismatch
Oct 17 16:15:13 MacBook authexec[1021]: executing /bin/ln
Oct 17 16:15:35 MacBook [0x0-0x39039].nl.frim.GitX[1018]: fatal: Not a git repository

The GitX window, of course, does reflect a git repository, but I'm not sure where/why Chax is coming into this.

Comments and changes to this ticket

  • Pieter de Bie

    Pieter de Bie October 18th, 2008 @ 12:12 AM

    Do you by any chance have the Safari 4 preview installed?

    Otherwise, could you try to uninstall Chax and try again?

  • Stephen Celis

    Stephen Celis October 18th, 2008 @ 12:18 AM

    • Tag changed from beachball to beachball, chax, safari4

    I do have Safari 4 installed. Are there compatibility issues?

  • Pieter de Bie

    Pieter de Bie October 18th, 2008 @ 11:56 AM

    • State changed from “new” to “invalid”
    • Tag changed from beachball, chax, safari4 to freeze, safari4

    Yes, GitX freezes if used with Safari 4, for more info see ticket #14.

    I'm going to close this ticket too.

  • Stephen Celis

    Stephen Celis October 18th, 2008 @ 03:22 PM

    The strange thing is that I have GitX running successfully on another computer with Safari 4 (though I am running Git 1.5.x on it, and Git 1.6.x on the newer, crashy one).

  • Pieter de Bie

    Pieter de Bie October 18th, 2008 @ 03:25 PM

    Perhaps you have an older version of GitX running there?

    Newest GitX only support git v1.5.4 and higher.. I'd doubt it the git version should matter much.

    You could try to uninstall safari 4 on the freezing box to test if that fixes the issue though.

    I'm afraid I can't help very much as I don't have Safari 4 installed and no desire to do so :) If you want to dig into this, you could try to disable JS calls in the .js files and see which one makes the program freeze. That should help diagnosis.

  • Stephen Celis

    Stephen Celis October 18th, 2008 @ 04:18 PM

    $A() was the culprit.

    commit.js:110

    -$A(commit.refs).each(function(ref) {
    +commit.refs.each(function(ref) {
    
    

    This fixes things. I'd have forked and patched it myself, but I wasn't sure if you were using $A() to account for null or undefined values. If so,

    -$A(commit.refs).each(function(ref) {
    +[commit.refs].flatten().compact().each(function(ref) {
    
    

    Works just as nicely, but with a bit more ugliness.

  • Pieter de Bie

    Pieter de Bie October 19th, 2008 @ 12:24 PM

    • State changed from “invalid” to “open”

    Very nice! I'll take a look at how I can make sure commit.refs returns an array.

    I was under the impression that I'd need to prototype-ify the commit.refs array before I could use the .each function, but apparently not.

    I think one of the things that should change in GitX is to drop Prototype -- in my experience so far, it's a slow POS that drags all the other code down.

  • Pieter de Bie

    Pieter de Bie October 19th, 2008 @ 02:39 PM

    • Milestone set to 0.5
  • Stephen Celis

    Stephen Celis October 19th, 2008 @ 02:55 PM

    I'd love to help out with the move away from Prototype. It's a nice utility library for quick, cross-browser development, but none of that is really necessary if IE is out of the fold.

  • Pieter de Bie

    Pieter de Bie October 19th, 2008 @ 09:26 PM

    • Title changed from “GitX beachballs on repo load” to “Prototype freezes OS X with Safari 4”

    It'd be very nice if you could help out! I made a start here:

    http://github.com/pieter/gitx/co...

    Some thinks might be useful to keep though, that's why I also started a GitX.js "library"

  • Stephen Celis

    Stephen Celis October 19th, 2008 @ 09:43 PM

    OK! Stop right there and I'll finish the job for you ;)

  • Stephen Celis
  • Pieter de Bie

    Pieter de Bie October 21st, 2008 @ 08:56 PM

    • State changed from “open” to “resolved”

    Fixed in 36c550f8cde71858a982be77c6fb8ec231149891 (Merge branch 'pu/pb/remove_prototype')

    Thanks.

  • mekupec
  • ronn91

    ronn91 July 2nd, 2019 @ 09:19 AM

    Thank you for sharing this data. Really increase in value the way you have describe everything in this article. Keep up the decent work.
    hotmail

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

GitX is the nice-looking gitk clone for OS X

People watching this ticket

Pages