#201 small
Eric

Network Reachability Check can take extended time

Reported by Eric | September 14th, 2009 @ 01:24 AM | in 0.8

I work on a segregated network with no Internet access. When I first started using GitX, it was hanging repeatedly. I eventually tracked this down to the -[PBWebController isReachable] call; it looks like SCNetworkCheckReachabilityByName is taking a while to return that the host isn't reachable.

I don't know how fixable this is, nor how common my network configuration would be. However, the app was clearly unusable. As far as I could tell, this check was only used in the Gravatar functionality check, in history.js setGravatar().

Since we'll never use this in my office, I just commented out the code. However, it sees like you move the Controller.isFeatureEnabled_("gravatar") check above the reachability for www.gravatar.com. We'd still see the lousy performance until we toggled the setting, but at least we'd be able to get GitX usable without needing to modify the code.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

GitX is the nice-looking gitk clone for OS X

People watching this ticket

Pages