#25 ✓resolved
Stephen Bannasch

feature: clickable list of files for commit

Reported by Stephen Bannasch | November 11th, 2008 @ 10:45 PM | in 0.6

Just cloned and built gitx -- first comment -- great work!

I've been using gitk and I miss the list of files in a commit.

When I view a commit I'm often very interested in the list of paths that have been changed by that commit. In gitk this list is available in a pane to the right of the pane that displays the commit message and diffs. This list always starts with an item named COMMENTS for the commit message.

Looking at the gitx UI I haven't come up with a better place to put that list but I don't like the UI very much. The paths that are changed by a commit can often be quite long -- this info wants to have a generous horizontal extent to display inside. But the commit diffs also look best in a wide pane.

One simple way for me to get some of what I'd like is just to list the affected paths under the commit message. I imagine this could be part of the html display and the listed paths could be links to anchors in the html for each diff.

Another simple help would be changing the action of command-downarrow to scroll the commit pane to the beginning of the next diff and command-uparrow to scroll to the beginning of the previous diff (or to the top of the commit message if at the beginning of the first diff.

Hmm ...

Comments and changes to this ticket

  • Stephen Bannasch

    Stephen Bannasch November 11th, 2008 @ 11:52 PM

    I've sent an email with a patch that adds keyboard navigation through the files in a commit using the 'f' and 'g'.

    It wasn't immediately clear (to me) how to find the keyboard event consisting of a ctrl key AND a down arrow in javascript.

    I should probably just fork your project on github so I can send you a pull request ... I'm guessing that would be easier for you to look at and review/comment ??

  • Pieter de Bie

    Pieter de Bie November 11th, 2008 @ 11:58 PM

    An email with a patch is fine :) However, I did not receive any emails

  • Stephen Bannasch

    Stephen Bannasch November 12th, 2008 @ 09:22 AM

    The email I constructed was wrong, but I've forked gitx on github and sent you a pull request.

    You can see a screenshot of the new UI here:

    http://github.com/stepheneb/gitx...

  • Pieter de Bie

    Pieter de Bie November 12th, 2008 @ 10:02 PM

    • State changed from “new” to “open”

    Looks good. I'll take a look at it soon and then hopefully merge it in.

    Thanks!

  • Stephen Bannasch

    Stephen Bannasch November 12th, 2008 @ 10:31 PM

    It could definitely use some UI/display tweaking.

    On some of my git repos the paths are quite long and the width of the message and filelist divs are too wide for a normal window and the filelist div ends up below the message div.

    I pushed the commits to my github fork of gitx -- first I unintentionally created a new branch in the remote called hg-fork, then I pushed my changes to my master branch.

    What is the best convention that makes it easiest for you to pull from (git still a bit new for me)?

  • Pieter de Bie

    Pieter de Bie November 16th, 2008 @ 03:15 PM

    I replied to your pull request separately, so I'm just going to reply to this:

    What is the best convention that makes it easiest for you to pull from (git still a bit new for me)?

    I don't really care how you submit your work. You can use github to push your commits and then send me a pull message. I'd prefer to have an email rather than a push message, so that I can reply to that immediately. I don't really like the github messaging part, because you can't use your mail client.

    You can also send me patches with your work (using, for example, git format-patch and git send-email). That way, I can reply to your commits in a mail message. This is useful if your patches need some modification.

    I do prefer patches/branches that are clean: They don't add or remove irrelevant parts of code, and the commits are logically ordered and have a clean commit message. This last parts includes commit subjects that fit on one line (less than 80 characters or so), and messages that are present tense rather than past tense (so "Add a one-line commit overview" instead of "Added a one-...".

    If you don't do that, I'll do it for you. Submitted patches will usually find their way in my own repository in the pu/initials/* branches, where I reformat them to my convention. If I react to your message with specific code improvements, it's often useful to check my repository to see if I did some of the changes already. You can then build on that, or send a message like "I'm ok with your changes"

    This message has gotten quite big, I'll add it to the Documentation/ or the wiki soon :)

  • Pieter de Bie

    Pieter de Bie January 30th, 2009 @ 01:07 AM

    • Milestone set to 0.6
    • State changed from “open” to “resolved”

    We now have a list of changed files in 0.6, so I guess this can be closed :)

  • Pervez

    Pervez March 25th, 2018 @ 12:03 PM

    I like limited via Know-how which in turn is made up of genuinely been recently designed, plus specially your tips distributed I'm going to irrefutably grown to be asking after. Now comply with below cash advance costa-mesa Get pleasure from exclusively for exceptional know-how.

  • funnyjokes

    funnyjokes April 20th, 2018 @ 03:42 AM

    Thanks for your sharing. Hope you can contribute more quality posts to this page. Thank you!
    color switch

  • hellenjos
  • Happy Khinda

    Happy Khinda June 14th, 2018 @ 09:21 AM

    I have the latest version of this software 2017, and the latest version of FTM 2017. A few days ago right after I installed the Book Creator, I was able to create a book. Today I tried to create a new book and it gave me an error when I tried to start the book creator. Did I do something wrong? Do I have to reinstall the Book Creator every time I want to create a new book? Any help will be appreciated. Thank you.
    Best Joule Sous Vide and Best Sandwich Maker

  • tarozexika
  • rahul

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

GitX is the nice-looking gitk clone for OS X

People watching this ticket

Pages