#49 ✓resolved
davetron5000 (at gmail)

When staging commits that are not whole file; selection goes back to first file in list

Reported by davetron5000 (at gmail) | December 17th, 2008 @ 09:20 PM

  1. Create some changes in several files (at least 4); make sure each file has change such that gitx allows you to stage only part of the changes
  2. Start gitx and go to the commit view
  3. Do not stage anything from the first file listed
  4. Select the second file
  5. Stage the first change in the second file

Expected: GitX should either remain in current file (if other changes are available for staging) or move onto the next file (of current file has no other changes for staging)

Observed: GitX selects the first file in the list.

Why:? If I'm going through picking individual bits for staging, it breaks up the workflow if I have to sometimes select the next file and sometimes not.

Comments and changes to this ticket

  • Pieter de Bie

    Pieter de Bie December 17th, 2008 @ 09:52 PM

    • State changed from “new” to “open”

    the problem here is that GitX reloads the status after staging something. This happens incrementally, so it might be that the file you previously selected has not yet been parsed while it is being filled with data. In that case, the selection is lost.

    The easy fix would be to not load the data incrementally, but I don't really like that. The other option is to make some kind of update model, which is a bit more complicated but gives nicer results.

  • Pieter de Bie
  • Pieter de Bie

    Pieter de Bie December 22nd, 2008 @ 09:33 PM

    • State changed from “open” to “resolved”

    Fixed in 8d729dae4c (CommitView: Don't change selection when refreshing)

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

GitX is the nice-looking gitk clone for OS X

People watching this ticket


Referenced by